Skip to content

Conversation

yuvmen
Copy link
Member

@yuvmen yuvmen commented Oct 3, 2025

Follow up to #100810 , registration was left out

@yuvmen yuvmen requested review from wedamija and Swatinem October 3, 2025 17:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 3, 2025
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need do register FileBlobIndex as a BulkModelDeletionTask?

@yuvmen
Copy link
Member Author

yuvmen commented Oct 3, 2025

Do we also need do register FileBlobIndex as a BulkModelDeletionTask?

oh yea thats actually a good catch, might speed things up, ill add it

@yuvmen yuvmen force-pushed the yuvmen/register-file-deletion-task branch from 1c3c3ed to 3a4c17a Compare October 3, 2025 18:34
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           master   #100898       +/-   ##
============================================
+ Coverage   66.51%    81.14%   +14.62%     
============================================
  Files        8608      8616        +8     
  Lines      381950    382240      +290     
  Branches    24032     24032               
============================================
+ Hits       254067    310180    +56113     
+ Misses     127555     71732    -55823     
  Partials      328       328               

@yuvmen yuvmen merged commit e191e36 into master Oct 3, 2025
64 checks passed
@yuvmen yuvmen deleted the yuvmen/register-file-deletion-task branch October 3, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants