ref(performance): Remove usage of deprecatedRouteProps from VitalDetail
#100923
+180
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
scttcper
reviewed
Oct 6, 2025
Comment on lines
22
to
25
| const mockNavigate = jest.fn(); | ||
| jest.mock('sentry/utils/useNavigate', () => ({ | ||
| useNavigate: () => mockNavigate, | ||
| })); |
There was a problem hiding this comment.
can also get the router back instead of mocking const {router} = render(<>) to do
expect(router.location).toEqual(something)
There was a problem hiding this comment.
nice, will switch over to that
scttcper
approved these changes
Oct 6, 2025
cvxluo
approved these changes
Oct 6, 2025
Comment on lines
22
to
26
| const mockNavigate = jest.fn(); | ||
| jest.mock('sentry/utils/useNavigate', () => ({ | ||
| useNavigate: () => mockNavigate, | ||
| })); | ||
|
|
There was a problem hiding this comment.
nit:
Suggested change
| const mockNavigate = jest.fn(); | |
| jest.mock('sentry/utils/useNavigate', () => ({ | |
| useNavigate: () => mockNavigate, | |
| })); | |
| jest.mock('sentry/utils/useNavigate', () => ({ | |
| useNavigate: () => jest.fn(), | |
| })); | |
seems to follow the rest of the codebase
There was a problem hiding this comment.
didn't do this only because i'm binding mockNavigate in order to expect toHaveBeenCalledWiths on it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates usage of
deprecatedRoutePropsforVitalDetail-sentry/views/performance/vitalDetail.https://www.notion.so/sentry/Frontend-TSC-Project-Remove-all-uses-of-deprecatedRouteProps-true-26a8b10e4b5d8015a6a2dd14f9d41dd7