fix(ui): always render tabs in insights/ai to avoid flash during first navigation #101068
Conversation
github-actions
bot
added
the
Scope: Frontend
|
|
||
| return ( | ||
| <Fragment> | ||
| {handle && 'module' in handle ? <AgentsPageHeader module={handle.module} /> : null} |
There was a problem hiding this comment.
note: I left out passing headerTitle={<Fragment>{getAIModuleTitle(organization)}</Fragment>} because headerTitle just falls back to domainTitle if it’s not present, and that does the exact same thing:
sentry/static/app/views/insights/pages/agents/agentsPageHeader.tsx
Lines 41 to 42 in 38fa875
| path: `${MODULE_BASE_URLS[ModuleName.AGENTS]}/`, | ||
| children: [ | ||
| { | ||
| index: true, | ||
| handle: {module: ModuleName.AGENTS}, | ||
| component: make(() => import('sentry/views/insights/agents/views/overview')), | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| path: `${MODULE_BASE_URLS[ModuleName.MCP]}/`, | ||
| children: [ | ||
| { | ||
| index: true, | ||
| handle: {module: ModuleName.MCP}, |
There was a problem hiding this comment.
note: I think it’s quite weird that these routes are part of the moduleRoutes object. That object gets passed to 4 different parent routes: frontend, backend, mobile and ai and should probably only contain things that we need everywhere or in multiple places.
But right now, that means I can go to urls like /insights/frontend/agents/ and it works because the route exists but it renders a non-sensical page: frontend header with the agents page :/
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2 participants
No description provided.