chore(eco): add pending deletion state for sentry app installs #101125
Conversation
cathteng
changed the title
github-actions
bot
added
the
Scope: Frontend
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| (existingData = []) => | ||
| existingData.map(i => | ||
| i.app.slug === sentryApp.slug ? {...i, status: 'pending_deletion'} : i | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Potential bug: The frontend optimistically sets an installation's status to 'pending_deletion', but the backend immediately deletes the record, causing state inconsistency.
-
Description: When a user uninstalls a Sentry App, the frontend sends a DELETE request and then optimistically updates the local state of the installation to have a status of
'pending_deletion'. However, the backend API endpoint immediately and synchronously deletes the installation record from the database, rather than marking it for asynchronous deletion. The backend does not support a'pending_deletion'status. This mismatch causes the frontend to display an installation as 'Pending Deletion' when it has already been removed from the backend, leading to state inconsistency and potential errors on subsequent data fetches for that installation. -
Suggested fix: Align the frontend and backend behavior. Either the backend should be updated to support asynchronous deletion with a
pending_deletionstatus, or the frontend should be changed to immediately remove the uninstalled application from its local state upon a successful DELETE API response, instead of setting the'pending_deletion'status.
severity: 0.65, confidence: 0.98
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
bestie you don't even knowwwww
There was a problem hiding this comment.
read my PR descriptionnnnnn
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| export const getSentryAppInstallStatus = (install: SentryAppInstallation | undefined) => { | ||
| if (install) { | ||
| if (install && install.status !== 'pending_deletion') { |
There was a problem hiding this comment.
Have we updated the APIs to return sentry apps that are pending deletion? Also, is there an enum we can reference for object status? Seems fairly generic.
There was a problem hiding this comment.
The status looks like this https://github.com/getsentry/sentry/pull/101125/files#diff-b2f09d35e3f0947a8312823f96c548de7361dc682c81b6f9c272b7a97408baf4R270
Everything is returned unless it has been "soft deleted", in which case the object manager will not return it
3 participants
Merge after #100930
When deleting a Sentry app install, we queue it for deletion in the above PR, so we should show this state to the FE.
After the DELETE call is successful, update the FE state of the current installation to
pending_deletionand also update buttons and labels.