feat(seer explorer): RPCs to query and visualize spans #101133
Conversation
github-actions
bot
added
the
Scope: Backend
![semgrep-code-getsentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101133 +/- ##
=========================================
Coverage 81.09% 81.10%
=========================================
Files 8666 8669 +3
Lines 384491 384639 +148
Branches 24268 24268
=========================================
+ Hits 311813 311967 +154
+ Misses 72333 72327 -6
Partials 345 345 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| logger.warning("No projects found for organization", extra={"org_id": org_id}) | ||
| return None | ||
|
|
||
| params: dict[str, Any] = { |
There was a problem hiding this comment.
what do you think about moving more of this logic to the caller? so that way this can basically be a passthrough
There was a problem hiding this comment.
hmm to me this stuff feels like a lot of internal implementation of querying sentry data though, rather than stuff seer should worry about
There was a problem hiding this comment.
it's transformations that seer needs to consume sentry data though right? shouldn't it live in seer? the more you can make this a passthrough interface, the easier it gets to add new ones if you need, IMO.
| ) | ||
| data = resp.data | ||
|
|
||
| # Normalize response format: single-axis returns flat format, multi-axis returns nested |
There was a problem hiding this comment.
also wondering if we can do this in the caller
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
3 participants
Adds RPC endpoints to:
These endpoints are used in Seer here.
These simulate calling the events and events-stats endpoints, which is what is used by the frontend to render the chart and table on Trace Explorer.