ref(stacktrace-link): Minor refactor #101154
Merged
+12
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's too much happening within the setUp call, thus, making it less clear when reading the tests what code mappings are being considered for the test. This makes it more clear.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Oct 8, 2025
| def get_stacktrace_config( | ||
| configs: list[RepositoryProjectPathConfig], | ||
| ctx: StacktraceLinkContext, | ||
| organization: Organization | None = None, |
There was a problem hiding this comment.
The organization is not used within the function.
| stack_root="sentry/", | ||
| source_root="src/sentry/", | ||
| automatically_generated=True, # Created by the automation | ||
| ) |
There was a problem hiding this comment.
We will let each test decide what code mappings makes sense to create rather than create it for each test.
cvxluo
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's too much happening within the setUp call, thus, making it less clear when reading the tests what code mappings are being considered for the test.
This makes it more clear.