fix(o11y): dont propagate traces for post process task #101189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
Oct 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101189 +/- ##
========================================
Coverage 81.08% 81.08%
========================================
Files 8672 8672
Lines 384683 384683
Branches 24280 24280
========================================
+ Hits 311917 311929 +12
+ Misses 72419 72407 -12
Partials 347 347 |
Updates test_dispatch_task_with_occurrence to expect the headers parameter added in the previous commit for disabling trace propagation.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "project_id": project_id, | ||
| "eventstream_type": eventstream_type, | ||
| }, | ||
| headers={"sentry-propagate-traces": False}, |
There was a problem hiding this comment.
Bug: Header Value Type Mismatch Causes Tracing Issues
The sentry-propagate-traces header uses a boolean False value. Headers typically expect strings, which could lead to serialization or processing issues in the tracing system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is causing traces that are far too large to view, and doesn't really help for debugging. let's not propagate traces here