feat(ILOC): allow custom URL schemas #101197
Open
+76
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101197 +/- ##
===========================================
+ Coverage 81.11% 81.17% +0.06%
===========================================
Files 8595 8624 +29
Lines 380872 382792 +1920
Branches 23899 23899
===========================================
+ Hits 308954 310746 +1792
- Misses 71556 71684 +128
Partials 362 362 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return data | ||
|
|
||
| if data == "": | ||
| self.fail("invalid") |
There was a problem hiding this comment.
Bug: URL Field Ignores Blank Allowance
The CustomSchemeURLField unconditionally rejects empty strings, even when allow_blank=True is configured. This bypasses the intended allow_blank behavior, causing validation to fail unexpectedly for empty inputs.
markstory
reviewed
Oct 9, 2025
Comment on lines
+38
to
+40
| parsed = urlparse(data) | ||
| if not parsed.scheme or not parsed.netloc: | ||
| self.fail("invalid") |
There was a problem hiding this comment.
Should we disallow custom schemes that overlap with known protocols? I'm thinking of things like file://, ftp://, irc://, mailto://, javascript://, odbc:// and s3://?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for custom redirect URI schemas to allow the mobile app to respond to a non-HTTP redirect for its auth. See https://www.notion.so/sentry/Seer-Mobile-Auth-2628b10e4b5d80e589dcdbb2e03782d5.