fix(detectors): Handle case where repeating_spans_compact is a list
#101222
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101222 +/- ##
===========================================
- Coverage 81.04% 81.04% -0.01%
===========================================
Files 8675 8675
Lines 384888 384891 +3
Branches 24312 24312
===========================================
Hits 311943 311943
- Misses 72586 72589 +3
Partials 359 359 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
shashjar
reviewed
Oct 9, 2025
| repeating_spans_compact = event.occurrence.evidence_data.get("repeating_spans_compact", "") | ||
| if isinstance(repeating_spans_compact, list): | ||
| repeating_spans_compact = repeating_spans_compact[0] | ||
| return repeating_spans_compact.replace("`", '"') |
There was a problem hiding this comment.
nit but if you feel this might be important enough to add a test that would be good
shashjar
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repeating_spans_compactcan be a list, not just a string. if it is, we should just take the first span and use that.