Skip to content

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Oct 9, 2025

A few improvements based on recent findings.

  1. Do not compare numeric values of incomplete buckets. This is generally pointless, those buckets don't have all the data, so they change a lot, and we don't really care about differences there
  2. Do not re-run comparison on data change. This causes huge log spikes in the Logs view, which re-loads the data a lot on live refresh. Instead, just react to loading state changes

They are very likely to have discrepancies that we don't care about
We don't want to run the comparison depending on the `data`, since it's
volatile.
@gggritso gggritso requested a review from DominikB2014 October 9, 2025 15:35
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 9, 2025
@gggritso gggritso marked this pull request as ready for review October 9, 2025 16:07
@gggritso gggritso requested a review from a team as a code owner October 9, 2025 16:07
@gggritso gggritso merged commit 16bb8d8 into master Oct 9, 2025
46 checks passed
@gggritso gggritso deleted the chore/timeseries/loosen-comprison branch October 9, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants