feat(tracemetrics): Show applicable group by options #101277
Merged
+101
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nsdeschenes
approved these changes
Oct 9, 2025
| const groupBys = useQueryParamsGroupBys(); | ||
| const setGroupBys = useSetQueryParamsGroupBys(); | ||
|
|
||
| const metricNameFilter = metricName ? `metric.name:"${metricName}"` : undefined; |
There was a problem hiding this comment.
We have a brand new MutableSearch you could try out here 🥺
narsaynorath
deleted the
narsaynorath/logs-404-show-applicable-group-by-options-in-select-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect the group by options by making a request to
trace-itemsfor attributes under the specific metric name. Also adds in some quick UI cleanup by removing dummy metric options and debug infoI had to update the
useTraceItemAttributeKeysto take a query prop and pass it along to the request.Screen.Recording.2025-10-09.at.2.44.39.PM.mov