-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(onboarding): Add Pydantic AI integration steps and links #101328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constantinius
wants to merge
1
commit into
master
Choose a base branch
from
constantinius/feat/onboarding/python-sdk-pydantic-ai-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The Pydantic AI getting started code snippet uses
OpenAIIntegration
without importing it, which will cause aNameError
when the code is executed.Description: The Python code snippet for the
pydanticAiStep
in the getting started documentation usesOpenAIIntegration
within thedisabled_integrations
list. However, it omits the necessary import statement forOpenAIIntegration
. When a user copies and executes this code, their application will raise aNameError
during thesentry_sdk.init()
call, preventing the application from starting. This pattern is inconsistent with other similar code snippets in the same file which correctly include the import.Suggested fix: Add
from sentry_sdk.integrations.openai import OpenAIIntegration
to the Python code snippet within thepydanticAiStep
component. This will resolve theNameError
by making the class available before it's referenced indisabled_integrations
.severity: 0.85, confidence: 1.0
Did we get this right? 👍 / 👎 to inform future reviews.