-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Move Event.data into abstract node storage #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Need some Riak experts in here to make sure I'm not abusing the store for the "overwrite this value always" operation /cc @dialtone |
I'm not an expert in Riak but... This probably depends on the storage backend: bitcask, eleveldb or even straight up memory. The other issue is that you need to make sure that keys are balanced, and no one key is more accessed than others. The issue with that is that the scaling happens across the hash range but if you only use a few keys for everything you can't really aggregate write/read performance and the benefits disappear. A partial way to solve the key hotness is to buffer writes for a short time before flushing them to the store. |
Conflicts: src/sentry/app.py src/sentry/conf/server.py src/sentry/models.py src/sentry/testutils.py
This allows us to split off the (very heavy) storage costs of Event.data and rely on SQL for what it's good at: indexing schemas.
This isn't ready to merge. Need to add some tests for the Riak backend, higher level integration, as well as do some manual QA