Mapped source URLs should be relative to the sourcemap. #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code made it relative to the original source URL, which may not be in the same location.
|
@mattrobenolt do you know much about the spec in this area? Just want to confirm that this wont cause any issues |
|
The spec doesn't say anything at all about it, but it makes sense to me. |
dcramer
added a commit
that referenced
this pull request
Dec 3, 2013
Mapped source URLs should be relative to the sourcemap.
|
Thanks. @mattrobenolt, the spec actually does mention it:
|
|
:( Reading is hard, apparently. |
|
@russelldavis Thanks for the attention to detail! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code made it relative to the original source URL, which may not
be in the same location.