Remove unused project attribute #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In client dev docs, an example shows a `"project"` attribute in the JSON packet. There's no mention of it anywhere else, and everything works brilliantly without it, so I figured it's probably worth nuking.
|
I think we forgot to update things when we killed this off as part of the data packet itself (instead we rely on the other provided data to determine it) |
dcramer
added a commit
that referenced
this pull request
Jan 6, 2014
Remove unused project attribute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In client dev docs, an example shows a
"project"attribute in theJSON packet.
There's no mention of it anywhere else, and everything works
brilliantly without it, so I figured it's probably worth nuking.