Skip to content

fix(webhooks): Include event ID (autoincrementing) in request body #11086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2018
Merged

fix(webhooks): Include event ID (autoincrementing) in request body #11086

merged 3 commits into from
Dec 18, 2018

Conversation

tkaemming
Copy link
Contributor

See ISSUE-237 for a lot more context. From that ticket:

This was "broken" as a result of post-processing changes that switched to using a Kafka consumer of the event stream as the mechanism for events being dispatched.

@tkaemming tkaemming requested a review from a team December 18, 2018 22:00
@tkaemming tkaemming merged commit e6cbd35 into master Dec 18, 2018
@tkaemming tkaemming deleted the webhook-id branch December 18, 2018 23:35
@tkaemming tkaemming mentioned this pull request Dec 19, 2018
Merged
tkaemming added a commit that referenced this pull request Dec 19, 2018
@tkaemming
fix(webhooks): Gracefully handle unsaved events in webhook actions (#…
409d001 
…11093)

References GH-11086.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@bretthoerner bretthoerner bretthoerner approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkaemming @bretthoerner