Skip to content

fix(webhooks): Gracefully handle unsaved events in webhook actions #11093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2018
Merged

fix(webhooks): Gracefully handle unsaved events in webhook actions #11093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/sentry/plugins/sentry_webhooks/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,13 @@ def get_group_data(self, group, event, triggering_rules):
data['event']['tags'] = event.get_tags()
data['event']['event_id'] = event.event_id
if features.has('organizations:legacy-event-id', group.project.organization):
data['event']['id'] = Event.objects.filter(
project_id=event.project_id,
event_id=event.event_id,
).values_list('id', flat=True).get()
try:
data['event']['id'] = Event.objects.filter(
project_id=event.project_id,
event_id=event.event_id,
).values_list('id', flat=True).get()
except Event.DoesNotExist:
data['event']['id'] = None
return data

def get_webhook_urls(self, project):
Expand Down