-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Move app instances into their respective modules #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7af70ba
to
b46db35
Compare
ab608d7
to
e0a5066
Compare
03928d0
to
59cc451
Compare
Security concerns found
Generated by 🚫 danger |
911e9b6
to
5b9d4ee
Compare
DONT WORRY! Its only like 500 lines changed... across 65 files. |
0dca0c3
to
06cc9d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good but i want to play around if the expose can be done better.
tests pass in sentry + getsentry, and some minor QA (clicking UI, workers doing work) seems to indicate things are good |
src/sentry/app.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta reimplement this real quick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
getting a few more quick tests in place then will get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing at all could go wrong here. 🥇
Result of playing around with the idea of killing off sentry.app
The monstrous hack of LazyBackendWrapper has benefits that its much easier to do module level imports (where we can't today due to circular imports).
As a followup we should:
#nochanges