Skip to content

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jun 25, 2015

Result of playing around with the idea of killing off sentry.app

The monstrous hack of LazyBackendWrapper has benefits that its much easier to do module level imports (where we can't today due to circular imports).

As a followup we should:

  • move sentry.utils.locking into sentry.locks
  • rename sentry.ratelimiter to sentry.ratelimits
  • create a base Service class which manages enabled() and validate() core methods
  • add a basic service registry to aid with things like "validate all services" (this might be able to use the provider code)

#nochanges

@dcramer dcramer force-pushed the refactor-app branch 3 times, most recently from 7af70ba to b46db35 Compare June 25, 2015 04:47
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Mar 3, 2017

1 Warning
⚠️ Changes require @getsentry/security sign-off

Security concerns found

  • src/social_auth/init.py
  • src/social_auth/backends/pipeline/user.py
  • src/social_auth/fields.py
  • src/sentry/web/frontend/accounts.py

Generated by 🚫 danger

@dcramer dcramer force-pushed the refactor-app branch 7 times, most recently from 911e9b6 to 5b9d4ee Compare March 3, 2017 20:48
@dcramer
Copy link
Member Author

dcramer commented Mar 3, 2017

DONT WORRY! Its only like 500 lines changed... across 65 files.

@dcramer dcramer force-pushed the refactor-app branch 2 times, most recently from 0dca0c3 to 06cc9d4 Compare March 3, 2017 21:00
Copy link
Contributor

@mitsuhiko mitsuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but i want to play around if the expose can be done better.

@dcramer
Copy link
Member Author

dcramer commented Mar 3, 2017

tests pass in sentry + getsentry, and some minor QA (clicking UI, workers doing work) seems to indicate things are good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta reimplement this real quick

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@dcramer
Copy link
Member Author

dcramer commented Mar 6, 2017

getting a few more quick tests in place then will get this merged

Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing at all could go wrong here. 🥇

@dcramer dcramer merged commit 6ee5bfe into master Mar 6, 2017
@dcramer dcramer deleted the refactor-app branch March 6, 2017 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants