Skip to content

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jun 10, 2016

  • New cell-based stack rendering
  • Hide line numbers and "application" notation
  • Add PHP specific rendering
  • Remove legacy CSS
  • Left-truncate filenames (expand on hover)
  • Add clipping to stack locals
  • Prevent propagation of clicks on ClippedBox
  • Dont collapse context on click (require header click)

screenshot 2016-06-11 17 02 30

TODO:

  • add way to expand/collapse stack locals
  • add way to expand/collapse all frames
  • tweak frame header details to be more concise based on language
  • confirm cocoa isn't broken
  • finalize visuals
  • indicator for app vs non-app frames
  • improve visuals when only single context line (remove active highlight?)
  • improve mouseover effects (no cursor) when no context
  • improve visuals around filename + function (truncation is awful in some cases like Java)
  • disable expand/collapse behavior when no context
  • rename "App Only" to "Focused" or something similar

@getsentry/ui

@dcramer
Copy link
Member Author

dcramer commented Jun 10, 2016

This is unfinished and I have not yet tested Cocoa

@dcramer dcramer force-pushed the new-stacktraces branch 10 times, most recently from f4e8ed2 to 00ead32 Compare June 11, 2016 23:34
@dcramer
Copy link
Member Author

dcramer commented Jun 11, 2016

This is live on staging

@dcramer dcramer force-pushed the new-stacktraces branch 6 times, most recently from 30a986b to 877b0c2 Compare June 13, 2016 19:46
@dcramer
Copy link
Member Author

dcramer commented Jun 14, 2016

@mitsuhiko is going to put this behind a feature switch

@mitsuhiko
Copy link
Contributor

@dcramer should we roll this out?

@dcramer
Copy link
Member Author

dcramer commented Jun 15, 2016

+1 -- we can probably push to staging without the switch enabled to make sure nothings butchered, but as long as we haven't regressed on the existing rendering no complaints here

dcramer and others added 3 commits June 16, 2016 00:23
- New cell-based stack rendering
- Add PHP specific rendering
- Remove legacy CSS
- Left-truncate filenames (expand on hover)
- Move message above exception
- Add clipping to stack locals
- Prevent propagation of clicks on ClippedBox
- Dont collapse context on click (require header click)

@getsentry/ui
@mitsuhiko mitsuhiko merged commit 924021f into master Jun 15, 2016
@mitsuhiko mitsuhiko deleted the new-stacktraces branch June 16, 2016 00:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants