fix(escalating_issues): Fix tests regression #48272
Conversation
There are some changes I picked up in #48247 which disable running tests since we need to import `TestCase` directly.
| from sentry.types.group import GroupSubStatus | ||
| from sentry.utils.cache import cache | ||
| from sentry.utils.snuba import to_start_of_hour | ||
|
|
||
| TIME_YESTERDAY = (datetime.now() - timedelta(hours=24)).replace(hour=6) | ||
|
|
||
|
|
||
| class BaseGroupCounts(SnubaTestCase): # type: ignore[misc] | ||
| class BaseGroupCounts(TestCase): # type: ignore[misc] |
There was a problem hiding this comment.
DailyGroupCountsEscalating inherits from BaseGroupCounts
If TestCase is not in the inheritance tree it stops executing.
This is why the tests got regressed in #48228 yet they did not turn the checks red.
| @@ -211,7 +210,7 @@ def test_is_escalating_issue(self, record_mock: MagicMock) -> None: | |||
|
|
|||
| # Test cache | |||
| assert ( | |||
| cache.get(f"daily-group-count:{group_escalating.project.id}:{group_escalating.id}") | |||
| cache.get(f"hourly-group-count:{group_escalating.project.id}:{group_escalating.id}") | |||
There was a problem hiding this comment.
This test started failing with the changes in #48228 but as I explained in the previous comment, we disabled the tests.
| @@ -241,18 +240,11 @@ def test_not_escalating_issue(self) -> None: | |||
|
|
|||
| @freeze_time(TIME_YESTERDAY.replace(minute=12, second=40, microsecond=0)) | |||
| def test_hourly_count_query(self) -> None: | |||
| """Test the hourly count query only aggregates events from today""" | |||
There was a problem hiding this comment.
I do not think this test is actually regressed but I cleaned it up a bit.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48272 +/- ##
==========================================
+ Coverage 80.91% 80.93% +0.01%
==========================================
Files 4773 4773
Lines 201862 201862
Branches 11521 11521
==========================================
+ Hits 163345 163370 +25
+ Misses 38262 38237 -25
Partials 255 255 |
| from sentry.types.group import GroupSubStatus | ||
| from sentry.utils.cache import cache | ||
| from sentry.utils.snuba import to_start_of_hour | ||
|
|
||
| TIME_YESTERDAY = (datetime.now() - timedelta(hours=24)).replace(hour=6) | ||
|
|
||
|
|
||
| class BaseGroupCounts(SnubaTestCase): # type: ignore[misc] | ||
| class BaseGroupCounts(TestCase): # type: ignore[misc] |
There was a problem hiding this comment.
You need SnubaTestCase here as well if you're using snuba in these tests. Otherwise we won't reset snuba afterwards and the tests will be unstable
There was a problem hiding this comment.
That's good to know.
I will follow up on this.
In PR #48272 we noticed that just inheriting from `SnubaTestCase` would no make the tests execute. Making `SnubaTestCase` inherit from `django.TestCase` fixes this.
There are some changes I picked up in #48247 which disable tests for
DailyGroupCountsEscalatingsince we needTestCaseto be in the inheritance tree.