feat(escalating_issues): Make tests inherit from SnubaTestCase #48332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR #48272 we noticed that just inheriting from `SnubaTestCase` would no make the tests execute. Making `SnubaTestCase` inherit from `django.TestCase` fixes this.
`SnubaTestCase` ensures to leave the snuba instance in a good state.
armenzg
changed the base branch from
armenzg/testing/make-snuba-test-case-run-tests
to
master
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48332 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 4774 4774
Lines 201756 201756
Branches 11521 11521
=======================================
+ Hits 163254 163260 +6
+ Misses 38247 38241 -6
Partials 255 255 |
jangjodi
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnubaTestCaseensures to leave the snuba instance in a good state.This is based on #48330