Skip to content

feat(replays): Remove scalar query optimization #61815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

feat(replays): Remove scalar query optimization #61815

merged 2 commits into from
Dec 19, 2023

Conversation

cmanallen
Copy link
Member

Fixes: #61418

@cmanallen cmanallen requested a review from a team as a code owner December 14, 2023 23:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 14, 2023
ryan953
ryan953 reviewed Dec 14, 2023
View reviewed changes
src/sentry/replays/usecases/query/__init__.py
Comment on lines -138 to -139
can_scalar_search_subquery,
scalar_search_config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these functions still used?

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

Merging #61815 (3aafe00) into master (decdc79) will increase coverage by 0.01%.
Report is 110 commits behind head on master.
The diff coverage is 58.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #61815      +/-   ##
==========================================
+ Coverage   81.20%   81.21%   +0.01%     
==========================================
  Files        5187     5187              
  Lines      228381   228697     +316     
  Branches    38310    38396      +86     
==========================================
+ Hits       185447   185729     +282     
- Misses      37294    37303       +9     
- Partials     5640     5665      +25
Files Coverage Δ
src/sentry/replays/usecases/query/__init__.py 88.88% <100.00%> (-2.99%) ⬇️
static/app/data/platformCategories.tsx 100.00% <ø> (ø)
src/sentry/replays/lib/new_query/parsers.py 75.00% <0.00%> (-12.50%) ⬇️
...try/replays/usecases/query/conditions/event_ids.py 86.30% <50.00%> (-2.93%) ⬇️

... and 77 files with indirect coverage changes

@cmanallen cmanallen merged commit ed3d807 into master Dec 19, 2023
@cmanallen cmanallen deleted the cmanallen/replays-remove-scalar-optimization branch December 19, 2023 14:45
@cmanallen cmanallen added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Dec 21, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 08821e1

getsentry-bot added a commit that referenced this pull request Dec 21, 2023
@getsentry-bot @cmanallen
Revert "feat(replays): Remove scalar query optimization (#61815)"
08821e1 
This reverts commit ed3d807.

Co-authored-by: cmanallen <6018782+cmanallen@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryan953 ryan953 ryan953 approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replay pagination is broken
3 participants
@cmanallen @getsentry-bot @ryan953