feat(traces): Add multiple queries for trace search #69929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multiple span conditions to be used together to target specific traces containing all (up to 3) of those conditions.
github-actions
bot
added
the
Scope: Frontend
Zylphrex
approved these changes
Apr 29, 2024
| // TODO: load tags for autocompletion | ||
| const organization = useOrganization(); | ||
| const canAddMoreQueries = queries.length <= 2; | ||
| const localQueries = queries.length ? queries : ['']; |
There was a problem hiding this comment.
This doesnt stop the user from editing the query string and injecting more queries right?
There was a problem hiding this comment.
no, basically if it's empty we pretend to have an array, otherwise we use the provided array
| } | ||
|
|
||
| export function TracesSearchBar({query, handleSearch}: TracesSearchBarProps) { | ||
| const getSpanName = (index: number) => { | ||
| const spanNames = [t('Span A'), t('Span B'), t('Span C')]; |
There was a problem hiding this comment.
Nit: move this into a constant outside the function
There was a problem hiding this comment.
In that case the translate function would run during import, which isn't a good tradeoff. Hiding consts in helpers is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows multiple span conditions to be used together to target specific traces containing all (up to 3) of those conditions.
Screenshots