Skip to content

Conversation

lauryndbrown
Copy link
Contributor

This is part of the Sentry 9 environments change. We want to filter UserReports by environment, but there currently doesn't exists an easy way of doing so. After talking with Ted and Matt, we decided to add an additional environment column to UserReports model to facilitate this filtering.

@lauryndbrown lauryndbrown self-assigned this Feb 8, 2018
@lauryndbrown lauryndbrown added this to the Sentry 9 milestone Feb 8, 2018
@ghost
Copy link

ghost commented Feb 8, 2018

2 Warnings
⚠️ You should update CHANGES due to the size of this PR
⚠️ PR includes migrations

Migration Checklist

  • new columns need to be nullable (unless table is new)
  • migration with any new index needs to be done concurrently
  • data migrations should not be done inside a transaction
  • before merging, check to make sure there aren't conflicting migration ids

Generated by 🚫 danger

@lauryndbrown lauryndbrown merged commit 17f2ddd into master Feb 8, 2018
@lauryndbrown lauryndbrown deleted the user-feedback branch February 8, 2018 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants