feat(uptime): Use subscriptions to process uptime messages. #73100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73100 +/- ##
==========================================
- Coverage 77.98% 77.98% -0.01%
==========================================
Files 6623 6625 +2
Lines 295551 295637 +86
Branches 50900 50923 +23
==========================================
+ Hits 230484 230546 +62
- Misses 58790 58810 +20
- Partials 6277 6281 +4
|
wedamija
commented
Jun 21, 2024
This abstracts the subscription processor and starts attempting to fetch subscriptions when processing results. To keep our dummy test case going, for now we'll create dummy models if the subscription can't be found.
wedamija
force-pushed
the
danf/uptime-use-subscriptions
branch
from
81547b1
to
4a89ecc
Compare
Comment on lines
81
to
86
| self.result_processor = self.result_processor_cls(get_topic_codec(topic)) | ||
|
|
||
| @property | ||
| @abc.abstractmethod | ||
| def result_processor_cls(self) -> type[ResultProcessor[T, U]]: | ||
| pass |
There was a problem hiding this comment.
lol it's a little confusing since it's a property
evanpurkhiser
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstracts the subscription processor and starts attempting to fetch subscriptions when processing results. To keep our dummy test case going, for now we'll create dummy models if the subscription can't be found.