feat(uptime): Tasks for automatic hostname detection and monitoring #73258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
commented
Jun 25, 2024
src/sentry/uptime/detectors/tasks.py
Outdated
| delete_candidate_urls_for_project(project) | ||
|
|
||
|
|
||
| def check_url(project: Project, project_url_count: int, url: str, url_count: int) -> bool: |
There was a problem hiding this comment.
Tbh I'd prefer to break most of the logic out of tasks.py but just haven't gotten around to it yet.
This implements most of the second half of automatic hostname detection and monitoring. It has a few components: - `schedule_detections` runs every minute. It looks at the last time it was run, and fires off tasks for each minute bucket. - `process_detection_bucket` runs for a specific datetime bucket. It just fetches all projects from this bucket and fires `process_project_url_ranking` for each of them. Note that each project will only belong to a single bucket. - `process_project_url_ranking` runs for a specific project. This is where the meat of the logic exists. We get the ranked list of urls collected from this project's event data and run it through various criteria to see whether we should attempt to monitor the url There are a fair few todos around that I need to finish up, as well as building the logic to send subscriptions to the topic for our rust consumer.
wedamija
force-pushed
the
danf/uptime-detector-tasks
branch
from
a4dfc6f
to
173a280
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73258 +/- ##
========================================
Coverage 78.01% 78.02%
========================================
Files 6632 6633 +1
Lines 296124 296222 +98
Branches 50999 51014 +15
========================================
+ Hits 231031 231137 +106
+ Misses 58807 58799 -8
Partials 6286 6286
|
evanpurkhiser
approved these changes
Jun 25, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements most of the second half of automatic hostname detection and monitoring. It has a few components:
schedule_detectionsruns every minute. It looks at the last time it was run, and fires off tasks for each minute bucket.process_detection_bucketruns for a specific datetime bucket. It just fetches all projects from this bucket and firesprocess_project_url_rankingfor each of them. Note that each project will only belong to a single bucket.process_project_url_rankingruns for a specific project. This is where the meat of the logic exists. We get the ranked list of urls collected from this project's event data and run it through various criteria to see whether we should attempt to monitor the urlThere are a fair few todos around that I need to finish up, as well as building the logic to send subscriptions to the topic for our rust consumer.