Skip to content

Conversation

wedamija
Copy link
Member

@wedamija wedamija commented Sep 9, 2024

This fixes the generate sql command to work correctly in new Django apps. It works by performing a diff of any new files in the migration folders compared to master. In a new app, this ends up including __init__.py, which causes the command to fail. Just excluding that file.

This fixes the generate sql command to work correctly in new Django apps. It works by performing a diff of any new files in the migration folders compared to master. In a new app, this ends up including `__init__.py`, which causes the command to fail. Just excluding that file.
@wedamija wedamija requested review from a team and saponifi3d September 9, 2024 23:09
@wedamija wedamija requested a review from a team as a code owner September 9, 2024 23:09
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 9, 2024
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wedamija wedamija enabled auto-merge (squash) September 9, 2024 23:21
@wedamija wedamija merged commit c375018 into master Sep 9, 2024
36 checks passed
@wedamija wedamija deleted the danf/generate-sql-init branch September 9, 2024 23:23
c298lee pushed a commit that referenced this pull request Sep 10, 2024
…ps. (#77220)

This fixes the generate sql command to work correctly in new Django
apps. It works by performing a diff of any new files in the migration
folders compared to master. In a new app, this ends up including
`__init__.py`, which causes the command to fail. Just excluding that
file.

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants