feat(dashboards): Create table for landing page table view #80945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Nov 20, 2024
| import {type DashboardListItem, DisplayType} from 'sentry/views/dashboards/types'; | ||
|
|
||
| describe('Dashboards - DashboardList', function () { | ||
| describe('Dashboards - DashboardTable', function () { |
There was a problem hiding this comment.
Suggested change
| describe('Dashboards - DashboardTable', function () { | |
| describe('Dashboards - DashboardGrid', function () { |
| /> | ||
| ); | ||
|
|
||
| expect(screen.getByTestId('empty-state')).toBeInTheDocument(); |
There was a problem hiding this comment.
Can we assert on the text so we can validate what the user behaviour?
| isLoading?: boolean; | ||
| }; | ||
|
|
||
| enum Keys { |
There was a problem hiding this comment.
Suggested change
| enum Keys { | |
| enum ResponseKeys { |
small nit, but just thinking that Keys is pretty generic, if we're going to make an enum we should make it clear what keys it's meant to be for
| function handleDelete(dashboard: DashboardListItem) { | ||
| deleteDashboard(api, organization.slug, dashboard.id) | ||
| .then(() => { | ||
| trackAnalytics('dashboards_manage.delete', { |
There was a problem hiding this comment.
Not important for now, but it may be interesting to add the view type (table, grid) to the event in case we see different behaviour on either page for actions like delete, duplicate, etc
There was a problem hiding this comment.
ooo ya good point. I'll make a ticket for that so I remember before we rollout 😄
| return <span>{dataRow[column.key]}</span>; | ||
| }; | ||
|
|
||
| function renderDashboardTable() { |
There was a problem hiding this comment.
We can unnest this function's body and it'll render the dashboard table
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80945 +/- ##
=======================================
Coverage 78.42% 78.43%
=======================================
Files 7211 7215 +4
Lines 319738 319731 -7
Branches 44008 44023 +15
=======================================
+ Hits 250749 250771 +22
+ Misses 62602 62573 -29
Partials 6387 6387 |
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
As part of creating table view for the dashboards landing page this PR creates the actual table with most of the fields that are present in the mockup (only column left to add is permissions/access column). Switching the toggle to list view will bring you to this page view. I've defaulted to 25 items per page (i'm not sure if there's a different amount we want to use). It's still under the feature flag `dashboards-table-view` which I only have access to atm. <img width="1512" alt="image" src="https://github.com/user-attachments/assets/89530817-cd94-4128-ad3a-fa1ea05851d6">
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
As part of creating table view for the dashboards landing page this PR creates the actual table with most of the fields that are present in the mockup (only column left to add is permissions/access column). Switching the toggle to list view will bring you to this page view. I've defaulted to 25 items per page (i'm not sure if there's a different amount we want to use). It's still under the feature flag `dashboards-table-view` which I only have access to atm. <img width="1512" alt="image" src="https://github.com/user-attachments/assets/89530817-cd94-4128-ad3a-fa1ea05851d6">
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
As part of creating table view for the dashboards landing page this PR creates the actual table with most of the fields that are present in the mockup (only column left to add is permissions/access column). Switching the toggle to list view will bring you to this page view. I've defaulted to 25 items per page (i'm not sure if there's a different amount we want to use). It's still under the feature flag `dashboards-table-view` which I only have access to atm. <img width="1512" alt="image" src="https://github.com/user-attachments/assets/89530817-cd94-4128-ad3a-fa1ea05851d6">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of creating table view for the dashboards landing page this PR creates the actual table with most of the fields that are present in the mockup (only column left to add is permissions/access column). Switching the toggle to list view will bring you to this page view. I've defaulted to 25 items per page (i'm not sure if there's a different amount we want to use). It's still under the feature flag
dashboards-table-viewwhich I only have access to atm.