Skip to content

ref(post-process): Use similarity project option instead of flag #81054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

ref(post-process): Use similarity project option instead of flag #81054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/tasks/post_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,8 +1205,8 @@ def process_plugins(job: PostProcessJob) -> None:


def process_similarity(job: PostProcessJob) -> None:
if job["is_reprocessed"] or features.has(
"projects:similarity-embeddings", job["event"].group.project
if job["is_reprocessed"] or job["event"].group.project.get_option(
"sentry:similarity_backfill_completed"
):
return

Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/tasks/test_post_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2436,9 +2436,9 @@ def assert_not_called_with(self, mock_function: Mock):
return
raise AssertionError("Expected safe_execute to not be called with similarity.record")

@with_feature("projects:similarity-embeddings")
@patch("sentry.tasks.post_process.safe_execute")
def test_skip_process_similarity(self, mock_safe_execute):
self.project.update_option("sentry:similarity_backfill_completed", int(time.time()))
event = self.create_event(data={}, project_id=self.project.id)

self.call_post_process_group(
Expand Down
Loading