Skip to content

fix(tagstore): Allow flag to overwrite logic #81062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(tagstore): Allow flag to overwrite logic #81062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/sentry/tagstore/snuba/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,14 +442,13 @@ def get_tag_keys_for_projects(
organization = Organization.objects.get_from_cache(id=organization_id)
if features.has("organizations:tag-key-sample-n", organization):
optimize_kwargs["sample"] = options.get("visibility.tag-key-sample-size")

# If we are fetching less than max_unsampled_projects, then disable
# the sampling that turbo enables so that we get more accurate results.
# We only want sampling when we have a large number of projects, so
# that we don't cause performance issues for Snuba.
# We also see issues with long timeranges in large projects,
# So only disable sampling if the timerange is short enough.
if len(projects) <= max_unsampled_projects and end - start <= timedelta(days=14):
elif len(projects) <= max_unsampled_projects and end - start <= timedelta(days=14):
optimize_kwargs["sample"] = 1

# Replays doesn't support sampling.
Expand Down
Loading