feat(onboarding-php): Uncheck profiling #85337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ArthurKnaus
commented
Feb 18, 2025
| disabledProducts: disabledProductsProp, | ||
| organization, | ||
| platform, | ||
| productsPerPlatform = platformProductAvailability, |
There was a problem hiding this comment.
Found out that this prop is not used anymore and removed it.
Will also clean it up in getsentry once this is merged.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #85337 +/- ##
==========================================
- Coverage 87.95% 87.95% -0.01%
==========================================
Files 9636 9636
Lines 544642 544641 -1
Branches 21146 21145 -1
==========================================
- Hits 479057 479056 -1
Misses 65279 65279
Partials 306 306 |
shellmayr
approved these changes
Feb 18, 2025
kahest
added a commit
that referenced
this pull request
Feb 27, 2025
Profiling has been removed from Android onboarding in #81322 Profiling is now more stable again and via #85337 we now also can choose which features should be selected by default. This PR - re-adds the Profiling feature to Android onboarding as inactive (opt-in) - adds an explainer comment to the Manual setup snippet which is shown when user activates Profiling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncheck profiling during the onboarding of php platforms.
Add mechanism to define the default product selection of platforms.