chore: remove biome

.github/CODEOWNERS

@@ -123,7 +123,6 @@ pyproject.toml                                           @getsentry/owners-pytho
 /.githib/worksflows/frontend.yml                         @getsentry/owners-js-build
 /.github/file-filters.yml                                @getsentry/owners-js-build
 babel.config.*                                           @getsentry/owners-js-build
-biome.json                                               @getsentry/owners-js-build
 build-utils/                                             @getsentry/owners-js-build
 eslint.config.mjs                                        @getsentry/owners-js-build
 jest.config.ts                                           @getsentry/owners-js-build

.pre-commit-config.yaml

@@ -108,12 +108,6 @@ repos:
       # additional_dependencies does not install a flattened dependency tree which is needed by,
       # for example, our eslint setup.
 
-      - id: biome
-        name: biome (javascript, typescript, json)
-        language: system
-        files: \.(jsx?|tsx?|css)$
-        entry: ./node_modules/.bin/biome check --log-level=error --write --files-ignore-unknown=true --no-errors-on-unmatched
-
       - id: eslint
         name: eslint
         language: system
@@ -129,7 +123,6 @@ repos:
       - id: prettier
         name: prettier (yaml, markdown, ts, tsx, js, jsx, css)
         language: system
-        # TODO: Remove tsx and jsx when Biome supports styled CSS formatting.
         types_or: [yaml, markdown, ts, tsx, javascript, jsx, css]
         entry: ./node_modules/.bin/prettier --log-level=error --write
         # https://pre-commit.com/#regular-expressions

.vercelignore

@@ -1,4 +1,3 @@
-
 !static
 !src
 !src/sentry
@@ -13,7 +12,6 @@
 !jest.config.js
 !now.json
 !package.json
-!biome.json
 !stylelint.config.js
 !tsconfig.json
 !config

.vscode/extensions.json

@@ -3,7 +3,6 @@
   // for the documentation about the extensions.json format
   "recommendations": [
     "esbenp.prettier-vscode",
-    "biomejs.biome",
     "mkhl.direnv",
     "ms-python.python",
     "ms-python.isort",

.vscode/settings.json

@@ -22,7 +22,6 @@
     "editor.tabSize": 2,
     "editor.defaultFormatter": "esbenp.prettier-vscode",
     "editor.codeActionsOnSave": {
-      "quickfix.biome": "explicit",
       "source.fixAll.eslint": "explicit"
     }
   },
@@ -60,21 +59,15 @@
     "editor.detectIndentation": false,
     "editor.tabSize": 2,
     "editor.formatOnSave": true,
-    "editor.defaultFormatter": "biomejs.biome",
-    "editor.codeActionsOnSave": {
-      "quickfix.biome": "explicit"
-    }
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
 
   "[yaml]": {
     "editor.insertSpaces": true,
     "editor.detectIndentation": false,
     "editor.tabSize": 2,
     "editor.formatOnSave": true,
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.codeActionsOnSave": {
-      "quickfix.biome": "explicit"
-    }
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
 
   "[markdown]": {
@@ -105,5 +98,6 @@
   "python.testing.pytestPath": "${workspaceFolder}/.venv/bin/pytest",
   "python.testing.pytestArgs": ["tests"],
   "python.analysis.autoImportCompletions": true,
-  "prettier.configPath": "package.json"
+  "prettier.configPath": "package.json",
+  "biome.enabled": false
 }

eslint.config.mjs

@@ -30,7 +30,6 @@ import typescriptSortKeys from 'eslint-plugin-typescript-sort-keys';
 import unicorn from 'eslint-plugin-unicorn';
 import globals from 'globals';
 import invariant from 'invariant';
-// biome-ignore lint/correctness/noNodejsModules: Need to get the list of things!
 import {builtinModules} from 'node:module';
 import typescript from 'typescript-eslint';
 
@@ -45,6 +44,9 @@ export const typeAwareLintRules = {
     '@typescript-eslint/await-thenable': 'error',
     '@typescript-eslint/no-array-delete': 'error',
     '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+    '@typescript-eslint/prefer-optional-chain': 'error',
+    '@typescript-eslint/consistent-type-exports': 'error',
+    '@typescript-eslint/consistent-type-imports': 'error',
   },
 };
 

package.json

@@ -175,7 +175,6 @@
     "zxcvbn": "^4.4.2"
   },
   "devDependencies": {
-    "@biomejs/biome": "^1.9.4",
     "@codecov/webpack-plugin": "^1.8.0",
     "@emotion/eslint-plugin": "^11.12.0",
     "@eslint/compat": "^1.2.7",
@@ -240,14 +239,12 @@
     "test-debug": "node --inspect-brk scripts/test.js --runInBand",
     "test-precommit": "node scripts/test.js --bail --findRelatedTests -u",
     "test-staged": "node scripts/test.js --findRelatedTests $(git diff --name-only --cached)",
-    "lint": "yarn lint:biome && yarn lint:prettier && yarn lint:js && yarn lint:css",
+    "lint": "yarn lint:prettier && yarn lint:js && yarn lint:css",
     "lint:js": "eslint",
     "lint:css": "stylelint '**/*.[jt]sx'",
-    "lint:biome": "biome check .",
     "lint:prettier": "prettier \"**/*.md\" \"**/*.yaml\" \"**/*.[jt]s(x)?\" --check --log-level=error",
-    "fix": "yarn fix:biome && yarn fix:prettier && yarn fix:eslint",
+    "fix": "yarn fix:prettier && yarn fix:eslint",
     "fix:eslint": "eslint --fix",
-    "fix:biome": "biome check . --write",
     "fix:prettier": "prettier \"**/*.md\" \"**/*.yaml\" \"**/*.[jt]s(x)?\" --write --log-level=error",
     "dev": "(yarn check --verify-tree || yarn install --check-files) && sentry devserver",
     "dev-ui": "SENTRY_UI_DEV_ONLY=1 SENTRY_WEBPACK_PROXY_PORT=7999 SENTRY_UI_HOT_RELOAD=1 webpack serve",

static/app/components/charts/groupStatusChart.tsx

@@ -48,14 +48,14 @@ function GroupStatusChart({
     emphasisColors: [string] | undefined;
     series: Series[];
   }>(() => {
-    if (!stats || !stats.length) {
+    if (!stats?.length) {
       return {colors: undefined, emphasisColors: undefined, series: []};
     }
     const max = Math.max(...stats.map(p => p[1]));
 
     const formattedMarkLine = formatAbbreviatedNumber(max);
 
-    if (showSecondaryPoints && secondaryStats && secondaryStats.length) {
+    if (showSecondaryPoints && secondaryStats?.length) {
       const series: Series[] = [
         {
           seriesName: t('Total Events'),

static/app/components/charts/pieChart.tsx

@@ -85,7 +85,7 @@ class PieChart extends Component<Props> {
 
   render() {
     const {series, theme, ...props} = this.props;
-    if (!series || !series.length) {
+    if (!series?.length) {
       return null;
     }
     if (series.length > 1) {

static/app/components/charts/utils.tsx

@@ -354,15 +354,15 @@ const DEFAULT_GEO_DATA = {
   data: [],
 };
 export const processTableResults = (tableResults?: TableDataWithTitle[]) => {
-  if (!tableResults || !tableResults.length) {
+  if (!tableResults?.length) {
     return DEFAULT_GEO_DATA;
   }
 
   const tableResult = tableResults[0]!;
 
   const {data} = tableResult;
 
-  if (!data || !data.length) {
+  if (!data?.length) {
     return DEFAULT_GEO_DATA;
   }
 

static/app/components/discover/transactionsTable.tsx

@@ -210,7 +210,7 @@ function TransactionsTable(props: Props) {
     if (isLoading) {
       return cells;
     }
-    if (!tableData || !tableData.meta || !tableData.data) {
+    if (!tableData?.meta || !tableData.data) {
       return cells;
     }
 

static/app/components/events/autofix/autofixChanges.tsx

@@ -295,9 +295,7 @@ export function AutofixChanges({
                 </ButtonBar>
               )}
               {prsMade &&
-                (step.changes.length === 1 &&
-                step.changes[0] &&
-                step.changes[0].pull_request?.pr_url ? (
+                (step.changes.length === 1 && step.changes[0]?.pull_request?.pr_url ? (
                   <LinkButton
                     size="xs"
                     priority="primary"

static/app/components/events/autofix/autofixDiff.tsx

@@ -662,7 +662,7 @@ export function AutofixDiff({
   previousInsightCount,
   isExpandable = true,
 }: AutofixDiffProps) {
-  if (!diff || !diff.length) {
+  if (!diff?.length) {
     return null;
   }