Skip to content

fix(ui): select menu positioning #93684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

fix(ui): select menu positioning #93684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions static/app/components/core/select/index.chonk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ export const getChonkStylesConfig = ({
width: 'auto',
minWidth: '100%',
maxWidth: maxMenuWidth ?? 'auto',
top: '100%',
marginTop: '8px',
}),
noOptionsMessage: provided => ({
...provided,
Expand Down
24 changes: 12 additions & 12 deletions static/app/components/core/select/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default Storybook.story('Select', (story, APIReference) => {
<p>
The <Storybook.JSXNode name="Select" /> component comes in different sizes:
</p>
<Storybook.SideBySide>
<Storybook.Grid>
<Select
size="md"
placeholder="medium"
Expand All @@ -42,15 +42,15 @@ export default Storybook.story('Select', (story, APIReference) => {
{value: 'item2', label: 'Item 2'},
]}
/>
</Storybook.SideBySide>
</Storybook.Grid>
</Fragment>
);
});

story('Disabled', () => {
return (
<Fragment>
<Storybook.SideBySide>
<Storybook.Grid>
<Select
isDisabled
size="md"
Expand Down Expand Up @@ -79,14 +79,14 @@ export default Storybook.story('Select', (story, APIReference) => {
{value: 'item2', label: 'Item 2'},
]}
/>
</Storybook.SideBySide>
</Storybook.Grid>
</Fragment>
);
});

story('With inFieldLabel', () => {
return (
<Storybook.SideBySide>
<Storybook.Grid>
<Select
inFieldLabel="Hello world"
size="md"
Expand Down Expand Up @@ -115,13 +115,13 @@ export default Storybook.story('Select', (story, APIReference) => {
{value: 'item2', label: 'Item 2'},
]}
/>
</Storybook.SideBySide>
</Storybook.Grid>
);
});

story('Clearable', () => {
return (
<Storybook.SideBySide>
<Storybook.Grid>
<Select
isClearable
defaultValue={{value: 'item1', label: 'Item 1'}}
Expand Down Expand Up @@ -152,13 +152,13 @@ export default Storybook.story('Select', (story, APIReference) => {
{value: 'item2', label: 'Item 2'},
]}
/>
</Storybook.SideBySide>
</Storybook.Grid>
);
});

story('Searchable', () => {
return (
<Storybook.SideBySide>
<Storybook.Grid>
<Select
isSearchable
size="md"
Expand Down Expand Up @@ -187,7 +187,7 @@ export default Storybook.story('Select', (story, APIReference) => {
{value: 'item2', label: 'Item 2'},
]}
/>
</Storybook.SideBySide>
</Storybook.Grid>
);
});

Expand All @@ -199,7 +199,7 @@ export default Storybook.story('Select', (story, APIReference) => {
<Storybook.JSXNode name="leadingItems" /> prop to add an icon to the left of the
option.
</p>
<Storybook.SideBySide>
<Storybook.Grid>
<Select
isSearchable
size="md"
Expand Down Expand Up @@ -242,7 +242,7 @@ export default Storybook.story('Select', (story, APIReference) => {
{value: 'item2', label: 'Item 2', leadingItems: <IconGraphBar />},
]}
/>
</Storybook.SideBySide>
</Storybook.Grid>
</Fragment>
);
});
Expand Down
Loading