Skip to content

feat(taskworker): Zstd compress process profile task #95545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025

Conversation

enochtangg
Copy link
Member

The taskworker platform now supports ZSTD compression. This PR enables it for sentry.profiles.task.process_profile.

@enochtangg enochtangg requested a review from a team as a code owner July 15, 2025 14:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 15, 2025
@@ -137,6 +138,7 @@ def encode_payload(message: dict[str, Any]) -> str:
times=2,
delay=5,
),
compression_type=CompressionType.ZSTD,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll end up double zipping here as the profiles consumer will do one zip, and then the taskworker system will zip again. This isn't ideal, but as an intermediary step it should be ok. We should test this locally to make sure we're not going to break the tasks.

cursor[bot]

This comment was marked as outdated.

@enochtangg enochtangg merged commit df5471b into master Jul 15, 2025
64 checks passed
@enochtangg enochtangg deleted the add-compression-to-process-profile-task branch July 15, 2025 16:27
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
The taskworker platform now supports ZSTD compression. This PR enables
it for `sentry.profiles.task.process_profile`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants