fix(profiling): fix chunked query strategy for flamegraph #97461
+39
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97461 +/- ##
==========================================
- Coverage 80.58% 80.58% -0.01%
==========================================
Files 8557 8557
Lines 376468 376549 +81
Branches 24468 24468
==========================================
+ Hits 303381 303436 +55
- Misses 72717 72743 +26
Partials 370 370 |
relying on self.snuba_params
Zylphrex
approved these changes
Aug 11, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
This fixes a bug for flamegraph chunked query strategy where, for chunks associated to a transaction (stored into the `ProfilerMeta`), we'd only use the latest "window" `[t-n, t-i]` instead of using the whole time-range scanned `[t-n, t]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug for flamegraph chunked query strategy where, for chunks associated to a transaction (stored into the
ProfilerMeta), we'd only use the latest "window"[t-n, t-i]instead of using the whole time-range scanned[t-n, t].