Skip to content

Conversation

eduardoyoti
Copy link
Collaborator

@eduardoyoti eduardoyoti commented Jul 3, 2018

At the moment the initialisation of the scenarios in the 3rd party app occurs in the onCreate of their Activity, which means that when the app is killed, that information gets lost.
Then the Intent coming from the Yoti app, wakes app the app, but the onCreate of the Activity is not called, therefore the SDK don't have the scenarios set up to continue with the process.

To solve this, we are moving the initialisation of the Scenarios in the SDK to the onCreate of the application itself.

ED-623

Tests

  • Check data is not lost
  • Install Sample app
  • Click on the "Share my phone" button
  • When the Yoti app is open, click in the recents button and kill the Sample app
  • Go back to Yoti and complete the share
  • Check that we have receive the result of the share successfully

Copy link
Contributor

@AdrienVioletYoti AdrienVioletYoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RobertLK
Copy link
Collaborator

Tested :shipit:

@eduardoyoti eduardoyoti merged commit 57b2726 into master Jul 25, 2018
@eduardoyoti eduardoyoti deleted the ED-623 branch July 25, 2018 10:16
mariasenosiain added a commit that referenced this pull request Apr 6, 2022
# This is the 1st commit message:

Update publication scripts & gradle configs.

Related to YM-26133

# The commit message #2 will be skipped:

# Set up gradle properties to work with aar.gradle 2.2.2
#
# Related to YD-26133

# The commit message #3 will be skipped:

# Add configurable app package
#
# YM-25986

# The commit message #4 will be skipped:

# Bump version and update CHANGELOG
#
# YM-25986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants