[ED-545] Forcing Yoti app to be opened when Yoti SDK button is pressed. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienVioletYoti
approved these changes
Jul 24, 2018
|
1st scenario fails (shows "something went wrong") because we already checked this in |
# Conflicts: # yoti-sdk/src/main/java/com/yoti/mobile/android/sdk/kernelSDK/KernelSDKIntentService.java
Improving "Yoti app not installed" case in Sample-app. ED-545
|
Tests passing now (I can't leave reviews or check the checkboxes so I might be missing some rights 😞 ) |
RobertLK
approved these changes
Aug 29, 2018
mariasenosiain
added a commit
that referenced
this pull request
Apr 6, 2022
# This is the 1st commit message: Update publication scripts & gradle configs. Related to YM-26133 # The commit message #2 will be skipped: # Set up gradle properties to work with aar.gradle 2.2.2 # # Related to YD-26133 # The commit message #3 will be skipped: # Add configurable app package # # YM-25986 # The commit message #4 will be skipped: # Bump version and update CHANGELOG # # YM-25986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we are hoping to avoid the user clicking the browser on the app chooser dialog, which could be the reason of the behaviour seen for this ticket.
https://lampkicking.atlassian.net/browse/ED-545
ED-545
Verification Tests
Yoti app not installed -> website
Make sure Yoti is not installed
Install the SampleApp2
Click on the "Share my phone" button
Check that the website is showed
Yoti app installed -> Yoti
Install Yoti app
Open the SampleApp2
Click on the "Share my phone" button
Check that the Yoti app is opened and show the share confirm screen
@lampkicking/android-dev