Append api prefix #211
Merged
Append api prefix #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4ecee47 in 17 seconds
More details
- Looked at
1456lines of code in11files - Skipped
3files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_4Mv0llCXhsEHzPIZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on d07cb1f in 20 seconds
More details
- Looked at
88lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/zep_python/client.py:53
- Draft comment:
The string formatting on this line uses$instead of{}. It should be:
api_url = f"{base_url}/{api_suffix}"
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_c49CyMDHmkzT4zp5
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| base_url = f"{env_api_url}/api/v2" | ||
| api_url = f"{env_api_url}/{api_suffix}" | ||
| else: | ||
| api_url = f"${base_url}/{api_suffix}" |
There was a problem hiding this comment.
The string formatting on this line uses $ instead of {}. It should be:
Suggested change
| api_url = f"${base_url}/{api_suffix}" | |
| api_url = f"{base_url}/{api_suffix}" |
paul-paliychuk
added a commit
that referenced
this pull request
Sep 26, 2024
* SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * Append api prefix (#211) * chore: rm chainlit example * chore: Add base url suffix in client constructor * fix: Assignment * chore: Version bump --------- Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
paul-paliychuk
added a commit
that referenced
this pull request
Sep 26, 2024
* SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * Append api prefix (#211) * chore: rm chainlit example * chore: Add base url suffix in client constructor * fix: Assignment * chore: Version bump * chore: Remove $ from fstring * chore: Fix typing --------- Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
paul-paliychuk
added a commit
that referenced
this pull request
Sep 26, 2024
* SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * SDK regeneration * Append api prefix (#211) * chore: rm chainlit example * chore: Add base url suffix in client constructor * fix: Assignment * chore: Version bump * chore: Remove $ from fstring * chore: Fix typing * SDK regeneration * SDK regeneration * chore: Remove fernignore from poetry toml and lock * SDK regeneration * chore: Readd pyproject.toml and poetry lock to fernignore --------- Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove
ecommerce-chainlitexample and appendapi/v2prefix tobase_urlinclient.py.ecommerce-chainlitexample, includingconfig.toml,translations,README.md,app.py,chainlit.md,chat_history_shoe_purchase.py,ingest.py,pyproject.toml, andshoe_data.py.api/v2prefix tobase_urlinZepandAsyncZepclasses inclient.py.This description was created by
for d07cb1f. It will automatically update as commits are pushed.