Append api sufix to base url #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: rm chainlit example * chore: Add base url suffix in client constructor * fix: Assignment
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7201b9a in 17 seconds
More details
- Looked at
136lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_XEy90cC7yyGVhkqO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| base_url = f"{env_api_url}/api/v2" | ||
| api_url = f"{env_api_url}/{api_suffix}" | ||
| else: | ||
| api_url = f"${base_url}/{api_suffix}" |
There was a problem hiding this comment.
The string interpolation here is incorrect. It should be an f-string without the dollar sign.
Suggested change
| api_url = f"${base_url}/{api_suffix}" | |
| api_url = f"{base_url}/{api_suffix}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Append
api/v2suffix to base URLs inZepandAsyncZepclasses and update documentation for cloud-specific features.api/v2suffix tobase_urlinZepandAsyncZepconstructors inclient.py.ZEP_API_URLenvironment variable is set, use it as the base URL with the suffix.base_url.memory/client.pyto specify thatfact_instructionandsummary_instructionare Zep Cloud only features.This description was created by
for 7201b9a. It will automatically update as commits are pushed.