Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index errors #2129

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Fix index errors #2129

merged 3 commits into from
Mar 8, 2023

Conversation

mockersf
Copy link
Contributor

@mockersf mockersf commented Mar 6, 2023

It is still possible to have cases of Error: We can't have a page called index.md in the same folder as an index section...:

  • if a folder containing an index.md has a subfolder containing a _index.md
  • if a folder containing an index.md has the same name as a folder containing a _index.md but not the same path

To fix both those cases, keep track of sections as their complete path instead of their separate components

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

@Keats
Copy link
Collaborator

Keats commented Mar 6, 2023

if a folder containing an index.md has a subfolder containing a _index.md

Wait does that even work? We should entirely ignore those

@mockersf
Copy link
Contributor Author

mockersf commented Mar 7, 2023

@Keats
Copy link
Collaborator

Keats commented Mar 7, 2023

Hmm https://github.com/bevyengine/bevy-website/tree/master/content/learn should definitely be _index.md instead of index.md since there are no assets.
That shouldn't change anything for the rendering of the site afaik except changing the template to render.

I'll leave it on for now will remove it for 0.18 (#2130)

@Keats Keats merged commit cd90fd0 into getzola:next Mar 8, 2023
Keats pushed a commit that referenced this pull request Mar 19, 2023
* consider sections by path instead of by component

* add tests

* update more tests
theowenyoung added a commit to theowenyoung/zola that referenced this pull request Mar 19, 2023
* 'master' of https://github.com/getzola/zola:
  Set release date
  Update changelog and disable clippy in CI for a bit
  Implement Default for LanguageOptions (getzola#2145)
  Fix cachebusting not working with binary files
  Fix tests
  Update changelog
  Use page.summary if available (getzola#2141)
  Update deps
  Remove dummy test
  Fix tests
  Update changelog
  Revert "Allow external links to start with "www.*" (getzola#2100)"
  Fix index errors (getzola#2129)
  Fix a page missing from e2e test
  Next verison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants