Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page.summary in Atom feeds if available, like RSS feeds already do #2141

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

IcyDefiance
Copy link
Contributor

@IcyDefiance IcyDefiance commented Mar 15, 2023

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

    The exact contents of the feed files aren't mentioned in the documentation.


This PR is motivated by a bug in Brave (brave/brave-browser#29072) that causes high CPU usage after visiting websites with large Atom feeds, which was noticed by a few people on https://bevyengine.org/.

I've already built that website with the change in this PR and it solved the issue for me, and considering that the RSS feed already uses summaries if they're available, it would be great if Atom feeds did the same thing.

@IcyDefiance IcyDefiance changed the title Use page.summary in Atom feeds if available, like in RSS feeds already do Use page.summary in Atom feeds if available, like RSS feeds already do Mar 15, 2023
@Keats Keats merged commit 2acaeb5 into getzola:next Mar 15, 2023
@Keats
Copy link
Collaborator

Keats commented Mar 15, 2023

Thanks!

Keats pushed a commit that referenced this pull request Mar 19, 2023
theowenyoung added a commit to theowenyoung/zola that referenced this pull request Mar 19, 2023
* 'master' of https://github.com/getzola/zola:
  Set release date
  Update changelog and disable clippy in CI for a bit
  Implement Default for LanguageOptions (getzola#2145)
  Fix cachebusting not working with binary files
  Fix tests
  Update changelog
  Use page.summary if available (getzola#2141)
  Update deps
  Remove dummy test
  Fix tests
  Update changelog
  Revert "Allow external links to start with "www.*" (getzola#2100)"
  Fix index errors (getzola#2129)
  Fix a page missing from e2e test
  Next verison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants