Include the glsl global name in entrypoint arguments. #5418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't address #5417 in the general case. See #5417 (comment). |
|
@teoxoy Please see the latest comments in #5417 (comment). I think one can argue this is a bug in the way the glsl FE synthesizes |
|
The test snapshots have to be regenerated. |
LegNeato
force-pushed
the
glsl_entry_arg_name
branch
from
fd0e01f to
01d9ce1
Compare
Done |
LegNeato
force-pushed
the
glsl_entry_arg_name
branch
from
01d9ce1 to
9cf694b
Compare
teoxoy
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5422.
This partially addresses #5417.