docs: Fix comment in COPY_BYTES_PER_ROW_ALIGNMENT to include copy_texture_to_buffer
#8029
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…texture_to_buffer` Both t2b and b2t uses [validating GPUTexelCopyBufferInfo](https://www.w3.org/TR/webgpu/#abstract-opdef-validating-gputexelcopybufferinfo), so `COPY_BYTES_PER_ROW_ALIGNMENT` needs to be respected in both. This is already correctly enforced by wgpu.
sagudev
commented
Jul 30, 2025
| pub type DynamicOffset = u32; | ||
|
|
||
| /// Buffer-to-texture copies must have [`bytes_per_row`] aligned to this number. | ||
| /// Buffer-texture copies must have [`bytes_per_row`] aligned to this number. |
There was a problem hiding this comment.
Buffer-texture is this clear enough that it works both ways?
There was a problem hiding this comment.
Seems good to me, I have been using it that way.
andyleiserson
approved these changes
Jul 30, 2025
| pub type DynamicOffset = u32; | ||
|
|
||
| /// Buffer-to-texture copies must have [`bytes_per_row`] aligned to this number. | ||
| /// Buffer-texture copies must have [`bytes_per_row`] aligned to this number. |
There was a problem hiding this comment.
Seems good to me, I have been using it that way.
ErichDonGubler
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both t2b and b2t uses validating GPUTexelCopyBufferInfo, so
COPY_BYTES_PER_ROW_ALIGNMENTneeds to be respected in both. This is already correctly enforced by wgpu.