Skip to content

Conversation

andyleiserson
Copy link
Contributor

See denoland/deno#29603

The #[undefined] attribute does not seem to work for the async methods GPUBuffer::map_async and GPUQueue::on_submitted_work_done, so those are not fixed.

Testing
The CTS is sensitive to the difference for Queue.submit(), which is why it previously returned undefined manually. No testing for the other functions.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@ErichDonGubler ErichDonGubler merged commit 61e5124 into gfx-rs:trunk Sep 27, 2025
41 checks passed
@andyleiserson andyleiserson deleted the push-vttmwnplypxl branch September 27, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants