Coding style #6
Merged
Coding style #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggppdk
pushed a commit
that referenced
this pull request
Dec 6, 2018
…or the joomla core Fixes #6 (joomla#12) * inital port to the joomla core * add com_mailto as supported form (requires joomla#20265) * install & update SQL & mark as core extension * bump version to trigger drone * new line & drone * implement consentbox text based on the work by @brianteeman thanks! * thanks drone * new line * doc block * rename plugin to ConfirmConsent * fix inine comments * typo thanks @sandewt * implement LanguageAssociations thanks @infograf768 * fix check * move the update sql's to its own files to avoid merge conflicts * fix postgresql file * thanks @infograf768 * fix problems fund by @infograf768 * extend description * implement modal support thanks @infograf768 * new text thanks @brianteeman * drone * add missing period * thanks @brianteeman * thanks @Sandra97 * remove Scalar types * fix association * fix comments thanks @sandewt * class var type * fix language string and us another namesprace * the 2nd field is package_id * the 2nd field is package_id * the 2nd field is package_id * add com_privacy.request
ggppdk
pushed a commit
that referenced
this pull request
Dec 6, 2018
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message joomla#7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message joomla#8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
ggppdk
added a commit
that referenced
this pull request
Dec 6, 2018
…ngle query, reduce 20, 50, 100 queries (page limit) to 1 (joomla#22117) * Categoy manager, get all counters via single query * Replace countItems() and countTagItems() methods with a reusuable counterRelations() method in ContentHelper class * CS * Since deploy version * Better ordering for states to property names array * Coding style (#6) * Removed unneeded parameter from counting methods * CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use coding standard/style