Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Sep 8, 2020

  • for the Editor validators to work properly it needs to call the commitChanges() at all time even when potentially invalid or value is unchanged so that the validator can be executed at all time
  • fixes #571

- for the Editor validators to work properly it needs to call the commitChanges() at all time even when potentially invalid or value is unchanged so that the validator can be executed at all time
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #574 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines         9816      9818    +2     
  Branches      3467      3468    +1     
=========================================
+ Hits          9816      9818    +2     
Impacted Files Coverage Δ
...odules/angular-slickgrid/editors/longTextEditor.ts 100.00% <ø> (ø)
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/dateEditor.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/editors/floatEditor.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/editors/integerEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/editors/selectEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/editors/sliderEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/textEditor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b138d...d4adacc. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(editors): all Editors should call commitChanges even when invalid fix(editors): all Editors should call commitChanges even when invalid, fixes #571 Sep 8, 2020
@ghiscoding ghiscoding merged commit fd052d1 into master Sep 8, 2020
@ghiscoding ghiscoding deleted the bugfix/editor-validators branch September 8, 2020 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate singleSelect editable is not firing onValidationError(e, args)

3 participants