Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • the alwaysShowVerticalScroll flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the alwaysShowVerticalScroll is set to True (see core lib PR #537)
  • requires core lib PR #537 to be merged and released

- the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537))
- requires core lib [PR #537](6pac/SlickGrid#537) to be merged and released
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #600   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       149           
  Lines         9946      9945    -1     
  Branches      3516      3515    -1     
=========================================
- Hits          9946      9945    -1     
Impacted Files Coverage Δ
.../angular-slickgrid/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd24727...e942b7b. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - fix(core): don't override alwaysShowVerticalScroll flag fix(core): don't override alwaysShowVerticalScroll flag Oct 14, 2020
@ghiscoding ghiscoding merged commit 4eb9237 into master Oct 14, 2020
@ghiscoding ghiscoding deleted the bugfix/frozen-dont-override-show-vertical-scroll branch October 14, 2020 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants