Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 17, 2020

  • center already existed but we can add alignCenter to be in line with the other alignRight Formatter
  • note also that there's no need for alignLeft since everything is aligned to the left in SlickGrid

Ghislain Beaulac added 2 commits November 17, 2020 15:09
- center already existed but we can add alignCenter to be in line with the other alignRight formatter
- note also that there's no need for alignLeft since everything is aligned to the left in SlickGrid
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #634 (bd653d4) into master (4539cc4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #634    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          151       153     +2     
  Lines        10269     10281    +12     
  Branches      3614      3464   -150     
==========================================
+ Hits         10269     10281    +12     
Impacted Files Coverage Δ
...ngular-slickgrid/formatters/alignRightFormatter.ts 100.00% <100.00%> (ø)
...ules/angular-slickgrid/formatters/boldFormatter.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/formatters/centerFormatter.ts 100.00% <100.00%> (ø)
.../app/modules/angular-slickgrid/formatters/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4539cc4...bd653d4. Read the comment docs.

@ghiscoding ghiscoding merged commit 3645d60 into master Nov 18, 2020
@ghiscoding ghiscoding deleted the feat/formatter-alignment branch November 18, 2020 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants