Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 3, 2021

  • fixes #689

TODOs

  • push a fix
  • add unit tests
  • add E2E Cypress tests

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #690 (7105dea) into master (277e627) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #690   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          157       157           
  Lines        10473     10474    +1     
  Branches      3680      3681    +1     
=========================================
+ Hits         10473     10474    +1     
Impacted Files Coverage Δ
...es/angular-slickgrid/services/extension.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277e627...7105dea. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - fix(plugin): recreate header menu w/adding column dynamically, fix #689 fix(plugin): recreate header menu w/adding column dynamically, fix #689 Feb 3, 2021
@ghiscoding ghiscoding merged commit 1b89e2f into master Feb 4, 2021
@ghiscoding ghiscoding deleted the bugfix/header-menu-with-dynamically-added-column branch February 4, 2021 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grid header menus not visible after adding column(s) dynamically

2 participants