Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • add an extra collection length check before rendering the Select Editor/Filter dropdown to avoid multiple-select.js throwing errors that it can't find list or items

- add an extra collection length check before rendering the Select Editor/Filter dropdown to avoid multiple-select.js throwing errors that it can't find list or items
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #700 (ad16259) into master (09ac192) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #700   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10590     10595    +5     
  Branches      3727      3728    +1     
=========================================
+ Hits         10590     10595    +5     
Impacted Files Coverage Δ
.../modules/angular-slickgrid/editors/selectEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/filters/selectFilter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ac192...ad16259. Read the comment docs.

@ghiscoding ghiscoding merged commit 61e6599 into master Feb 23, 2021
@ghiscoding ghiscoding deleted the bugfix/multiple-select-enhancements branch February 23, 2021 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants